Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scaffold): allow for multiple generators + walletd client #933

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat(scaffold): allow for multiple generators + walletd client #933

merged 1 commit into from
Feb 9, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Feb 9, 2024

Description

feat(scaffold): allow for multiple generators
Allow use to specify a config for scaffold generators
Adds initial walletd client

Motivation and Context

Refactor scaffolder to allow for generator to be specified via cli
Adds an incomplete wallet client js library (written in ts using bindings)

How Has This Been Tested?

Running scaffolder

cargo run --release --bin tari_scaffolder --  -c ./scaffolder.json -g rust-template-cli scaffold ~/path/to/template.wasm

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

Test Results (CI)

438 tests  ±0   438 ✅ ±0   2h 17m 38s ⏱️ + 14m 42s
 57 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit b0854e7. ± Comparison against base commit 610b6e5.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the scaffolder-multiple-generators branch 2 times, most recently from 4d5725b to b8a4066 Compare February 9, 2024 13:37
@sdbondi sdbondi force-pushed the scaffolder-multiple-generators branch from b8a4066 to b0854e7 Compare February 9, 2024 13:56
@stringhandler stringhandler added this pull request to the merge queue Feb 9, 2024
Merged via the queue into tari-project:development with commit 6b69aff Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
P-acks_required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdbondi @stringhandler @ghpbot-tari-project